fix: Increase boot request queue limit #3340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrederikBolding
force-pushed
the
fb/bump-boot-queue-limit
branch
from
733518e to
2be0f0e
Compare
david0xd
approved these changes
Apr 22, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3340 +/- ##
=======================================
Coverage 97.80% 97.80%
=======================================
Files 364 364
Lines 9911 9911
Branches 1616 1616
=======================================
Hits 9693 9693
Misses 218 218 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase the limit of the
RequestQueueto100pending requests. This request queue is only used when the Snap has not yet booted, to detect issues where the Snap is failing to boot. The current limit of5seems too low to hit accidentally, therefore100was chosen which seems less likely to hit with a real use-case.